DiscImageCreator

[user7]

sarami, I've been told that the TSST TS-H352 supports C2 with data tracks, but not support C2 with audio tracks.

However when trying to dump a DC disc with a single data track in the HD area I get the error "[WARNING] This drive doesn't support reporting C2 error. Disabled /c2".

I'm curious how you're determining if a drive supports c2?
Can you can add support for c2 on data tracks for drives that support just c2 on data tracks? It would make dumping DC discs with 1 data track in the HD Area a lot easier.

[sarami]

TSST TS-H352 supports C2 with data tracks, but not support C2 with audio tracks.

However when trying to dump a DC disc with a single data track in the HD area I get the error "[WARNING] This drive doesn't support reporting C2 error. Disabled /c2".

DIC dumps data sector as "audio" to get the scrambled sector.

[reentrant]

Plextor 760: I have a disc with small C2 errors and I think current DIC doesn't handle C2 rereading properly:

Code: Select all

                 ofs: 11c, 11d, 127, 1d4, 1d5, 1df, 272, 273, 297, 32a, 32b, 365, 3e2, 3e3, 3f2, 3f3, 41d, 4aa, 4ab, 4b0, 4b1, 4d5, 562, 563, 568, 569, 620, 621, 630, 631, 
 LBA[080785], LBA translation to SCM address in hex[0xb534430], LBA in C2 file[0x16a6886] Detected C2 error 30 bit
                 ofs: 1dc, 1dd, 1e7, 294, 295, 29f, 332, 333, 357, 3ea, 3eb, 425, 4a2, 4a3, 4b2, 4b3, 4dd, 56a, 56b, 570, 571, 595, 622, 623, 628, 629, 
 LBA[080813], LBA translation to SCM address in hex[0xb544570], LBA in C2 file[0x16a88ae] Detected C2 error 26 bit
LBA[080785, 0x13b91]: crc32[000]: 0x5a6d23bd good. Rewrote .scm[190006288-190008639(b534410-b534d3f)] .c2[23750790-23751083(16a6886-16a69ab)]
LBA[080813, 0x13bad]: crc32[000]: 0xc20ab857 good. Rewrote .scm[190072144-190074495(b544550-b544e7f)] .c2[23759022-23759315(16a88ae-16a89d3)]

Code: Select all

LBA[311456, 0x4c0a0], MSF[69:14:56], mode 1
LBA[311457, 0x4c0a1], MSF[69:14:57], mode 1
[ERROR] Number of sector(s) where user data doesn't match the expected ECC/EDC: 2
    Sector: 80785, 80813, 
Total errors: 2

Sarami, can you check the algorithm and verify it rereads / writes correct bytes?

[sarami]

an you check the algorithm and verify it rereads / writes correct bytes?

If there are not non-zero byte in your .c2 file, the drive judges there are not c2 errors in your disc.

[reentrant]

There are non-zero bytes in C2 file. I did some analysis of logs / files and came to a conclusion that sth is wrong with parsing C2 / writing to SCM.

Code: Select all

                 ofs: 1d4, 1d5, 1df, 272, 273, 297, 32a, 32b, 365, 3e2, 3e3, 3f2, 3f3, 41d, 4aa, 4ab, 4b0, 4b1, 4d5, 562, 563, 568, 569, 620, 621, 630, 631, 
 LBA[080785], LBA translation to SCM address in hex[0xb534430], LBA in C2 file[0x16a6886] Detected C2 error 27 bit

Next step: verification of SCM writes:
1) Extract sector 080785 from SCM file prior to rereading -> File A
2) Extract sector 080785 from SCM file after rereading -> File B
3) Compare File A <=> File B
4) Differences at offsets: F4 and F5, and 2 more. The thing is that offsets F4 and F5 can't be written to according to C2 pointers. I have also verified that the writes to F4 and F5 offsets inject wrong data which result in extra errors after descrambling.

Then I attempted to repair the image in cdmage and extracted 080785 sector (2 files - before and after repairing).
Then I tried to match differences between those both 2 files and C2 file. C2 pointers matched after I shifted the sector by 40 bytes (see attachment - UNFIXED_SECTOR file). So maybe Plextor 760 has some additional C2 shift?

Another thing is that it looks like single bit in C2 file should be treated as if there were 2 erroneous bytes in image file. Some bits are not reported in C2 file and 2 bytes are bad in image. It's weird.

Disc info:

Code: Select all

========== Offset (Drive offset refers to http://www.accuraterip.com) ==========
     Combined Offset(Byte)     32, (Samples)     8
    -   Drive Offset(Byte)    120, (Samples)    30
    ----------------------------------------------
           CD Offset(Byte)    -88, (Samples)   -22
    Overread sector: 1
    SubChannel Offset: 0

Btw, is the C2 file using combined offset? 40bytes = 10 samples vs 8 samples combined offset, this gives 2 samples offset in C2. What is this? Some versions of PX760 have different C2 offsets?

Please look at it and try to fix it.

EDIT: have a look at this:

Code: Select all

if (IsPlextor712OrNewer(pDevice)) {
    BOOL bRetA = ContainsC2Error(pDevice, 1, CD_RAW_READ_C2_294_SIZE, lpNextBuf, &pDiscPerSector->uiC2errorNum, nLBA, FALSE);
    UINT c2ErrorBak = pDiscPerSector->uiC2errorNum;
    BOOL bRetB = ContainsC2Error(pDevice, 0, 1, lpNextBuf + CD_RAW_SECTOR_WITH_C2_294_AND_SUBCODE_SIZE, &pDiscPerSector->uiC2errorNum, nLBA, FALSE);
    pDiscPerSector->uiC2errorNum += c2ErrorBak;

    bRet = bRetA == RETURNED_NO_C2_ERROR_1ST ? bRetB : bRetA;
}

In your implementation first bRet was overwritten with 2nd one

EDIT2:
After I applied fix above C2 rereading algorithm started to work but I don't know why since there's that 40bytes SCM / C2 offset. Weird

[Foxhack]

What is the command to dump an HD DVD? I tried using the program to dump one, but it closes after it gets the error shown here.

Code: Select all

StartTime: 2023-03-24T22:44:53-0700
Set the drive speed: 22160KB/sec
[F:DVDGetRegion][L:472] GetLastError: 1, Incorrect function.

DiskSize of [F:\MPF_25-net48 [6a4b6d6 Stable]\ISO\300_HDDVD]
        Total:  2000397791232 bytes
         Used:  1859268304896 bytes
        ---------------------------
        Space:   141129486336 bytes
         => There is enough disk space for dumping

The wiki has the command line parameters for cd, bd and dvd, but not hddvd...

[sarami]

After I applied fix above C2 rereading algorithm started to work

Thanks debugging and patching. I also confirrmed that your patch is working.

Another thing is that it looks like single bit in C2 file should be treated as if there were 2 erroneous bytes in image file. Some bits are not reported in C2 file and 2 bytes are bad in image. It's weird.

Yes, it's known issue. For this reason, C2 error disc sometimes doesn't recover if the drive doesn't return C2.

is the C2 file using combined offset?

I deleted it. https://github.com/saramibreak/DiscImag … b1da037109

[reentrant]

Ok, but how to explain the following:
- That I had to shift data sector by 40 bytes to match c2 pointers?
- That C2 file size is not 8 times smaller than SCM file (C2 = 91568946 / SCM = 732549216)? It looks like C2 doesn't contain pointers from single sector, last one?

[Foxhack]

sarami, DIC does not let me dump an HD DVD disc using a Toshiba TS-L802A drive (this is an HD DVD drive for laptops that connects via slim IDE.) I plugged it into a USB laptop drive adapter, and it can read discs fine, but it won't let me dump an HDDVD because it shows me that error above ([F:DVDGetRegion][L:472] GetLastError: 1, Incorrect function.)

Is there anything I can do? I just want to dump my discs.

[sarami]

Ok, but how to explain the following:

For this issue?  https://github.com/saramibreak/DiscImag … issues/154

it won't let me dump an HDDVD because it shows me that error above ([F:DVDGetRegion][L:472] GetLastError: 1, Incorrect function.)

I tried to dump HDDVD using GGW-H20N and it's no problem. Its error is not related.