Page 1 of 1

Suggestion: Add SHA-256

Posted: Sat Jan 11, 2020 1:40 pm
by Hiccup
CRC32, MD5 and SHA-1 are all broken and it will just become easier for people to misuse their weakness in the future. I suggest that redump adds a field for SHA-256 to disc pages. Or even if iR0b0t doesn't want to add a new field, the data could be added in the comment field. Of course for discs added before this change, the information will have to be added retroactively as fixes.

Re: Suggestion: Add SHA-256

Posted: Sat Jan 11, 2020 2:01 pm
by ssjkakaroto
Why would anyone try to crack the hashes of games' images? SHA-1 is even an overkill for the purposes of redump.org, SHA-256 would be absolutely redundant.

Re: Suggestion: Add SHA-256

Posted: Sat Jan 11, 2020 3:02 pm
by Hiccup
"Why would anyone try to crack the hashes of games' images?"
Just to mislead people.

Re: Suggestion: Add SHA-256

Posted: Sat Jan 11, 2020 3:52 pm
by reentrant
Any of CRC32, MD5 and SHA-1 is not secure. But all combined?

Re: Suggestion: Add SHA-256

Posted: Sun Jan 12, 2020 12:56 am
by Maddog
reentrant wrote:Any of CRC32, MD5 and SHA-1 is not secure. But all combined?
All combined and with a specific file size as per current dats should be an astronomically small chance of a hash collision, even if someone tried to do this intentionally. I don't think our roms can be faked with current level of knowledge.

Re: Suggestion: Add SHA-256

Posted: Mon Jan 13, 2020 11:17 am
by Hiccup
I don't think its practical to fake ROMs currently, but in the future it may be, so I think it'd be a good idea to get future-proof hashes before that point arrives.

Re: Suggestion: Add SHA-256

Posted: Mon Jan 13, 2020 12:27 pm
by wiggy2k
didn't it take google engineers like 100 years of CPU time to do a POC collision for SHA-1 ?

edit:  nope i was a mile off,

    Nine quintillion (9,223,372,036,854,775,808) SHA1 computations in total
    6,500 years of CPU computation to complete the attack first phase
    110 years of GPU computation to complete the second phase

I don't think we have anything to be worried about there for the forseable future.