Page 339 of 354
Re: DiscImageCreator
Posted: Sun Mar 26, 2023 5:29 am
by reentrant
sarami, I checked this topic and noticed one thing:
"It does seem that the .c2 file includes the missing sector now. Ideally it would be great if DIC would output 'corrected' .c2/log files that reflect the locations in the scm. That means a version of the .c2 with combined offset, additional offset (if present for certain drives), and reported c2 ofs."
Small progress: I think that these numbers (ofs):
Code: Select all
ofs: 3e2, 3e3, 3f2, 3f3, 41d, 4aa, 4ab, 4b0, 4b1, 4d5, 562, 563, 568, 569, 620, 621, 630, 631,
LBA[080785], LBA translation to SCM address in hex[0xb534430], LBA in C2 file[0x16a6886] Detected C2 error 18 bit
..
LBA[080785, 0x13b91]: crc32[078]: 0xba9f0657 good. Rewrote .scm[190006288-190008639(b534410-b534d3f)] .c2[23750790-23751083(16a6886-16a69ab)]
Should be interpreted as being shifted by combined offset if you try to match these pointers to specific sector in SCM.
In my example dump I had to shift data by 40 bytes but combined offset is 8 samples = 32bytes. It's still a question why I had to shift data by additional 8 bytes (2 samples). I have a feeling that not all Plextors 760 have equal C2 offset...
Re: DiscImageCreator
Posted: Sun Mar 26, 2023 6:50 am
by sarami
reentrant wrote:Should be interpreted as being shifted by combined offset if you try to match these pointers to specific sector in SCM.
It's easy to add the combined offset value to "ofs: xxx".
ofs: 3e2 + 0x20, 3e3 + 0x20, ...
But if it also applies to .c2 file, it needs to be shfted to right by 0x20 bits. It's very complicated.
reentrant wrote:It's still a question why I had to shift data by additional 8 bytes (2 samples). I have a feeling that not all Plextors 760 have equal C2 offset...
I have no idea. If you have other 760 drive, you can try it.
Re: DiscImageCreator
Posted: Sun Mar 26, 2023 8:50 am
by reentrant
"It's easy to add the combined offset value to "ofs: xxx"."
Could you add such line to c2 log file (with offset corrected c2 pointers - "ofs corrected:")? It's tricky because you already print offset corrected base of sector in SCM file.
EDIT:
Just found a nice info from ehw about c2 offset correction (
https://github.com/saramibreak/DiscImag … issues/154):
It's actually what I see - 8 bytes difference! I think that without taking into account that additional offset value c2 rereading algorithm is not correct. Plz could you also implement this - it's so close to have a perfect c2 rereading algorithm
Re: DiscImageCreator
Posted: Sun Mar 26, 2023 10:33 am
by Foxhack
sarami wrote:I tried to dump HDDVD using GGW-H20N and it's no problem. Its error is not related.
... so is there anything I can do to see
why this error is happening? It's clearly doing something DIC doesn't like, and I don't know how to send you that information so it can be fixed.
Re: DiscImageCreator
Posted: Sun Mar 26, 2023 1:06 pm
by sarami
reentrant wrote:It's actually what I see - 8 bytes difference! I think that without taking into account that additional offset value c2 rereading algorithm is not correct. Plz could you also implement this - it's so close to have a perfect c2 rereading algorithm
8 bytes difference --- It's 1 byte (8 bits) for .c2 file. then at that time, I understood "Additional Offset" that ehw says is "PX-712 or newer drive have 295 byte offsets, not 294".
Foxhack wrote:why this error is happening?
Merely HDDVD drive doesn't support DVDGetRegion. Same error occurs for my GGW-H20N.
Btw, other application (e.g. isobuster) can dump your disc? How many HDDVD do you have? All HDDVD you have can't be dumped?
Re: DiscImageCreator
Posted: Sun Mar 26, 2023 3:42 pm
by reentrant
Ok. I think I know where's the problem = confusion. Arguments to function "ContainsC2Error" look correct but this not 1:1 correlated to arguments to "WriteC2". In other words to have a perfect C2 file arguments to WriteC2 function has to be modified too in the same manner.
Btw, this line of code:
Code: Select all
else {
bRet = ContainsC2Error(pDevice, 0, CD_RAW_READ_C2_294_SIZE, lpNextBuf, &pDiscPerSector->uiC2errorNum, nLBA, FALSE);}
I think when you specify "lpNextBuf" you assume 294 C2 offset but what for drives that have 0 C2 offset?
Maybe it should be like that:
Code: Select all
if(Plextor712+) {assume 295 offset);}
else if(Plextor) {assume 294 offset);}
else {assume 0 offset);}
Re: DiscImageCreator
Posted: Sun Mar 26, 2023 10:24 pm
by sarami
reentrant wrote:I think when you specify "lpNextBuf" you assume 294 C2 offset but what for drives that have 0 C2 offset?
Maybe it should be like that:
I've not confirmed the c2 offset of the non-plextor drive, but I'll add it.
Edit
added
https://www.mediafire.com/file/eq80y20l … st.7z/file
Re: DiscImageCreator
Posted: Mon Mar 27, 2023 1:07 am
by reentrant
Thx. Btw, could you also add command line parameter for setting c2 offset value (if there's no value assume 0)?
Re: DiscImageCreator
Posted: Mon Mar 27, 2023 1:29 am
by Foxhack
sarami wrote:Merely HDDVD drive doesn't support DVDGetRegion. Same error occurs for my GGW-H20N.
Btw, other application (e.g. isobuster) can dump your disc? How many HDDVD do you have? All HDDVD you have can't be dumped?
I tried using Aaru to dump the disc, but the drive overheated after some time, and shut off. I thought the drive was completely dead, but it started working again after I let it rest.
Isobuster said I could dump the disc, but it wouldn't be sure if it'd work due to encryption.
The disc was 300 (so you know, one of the rotting discs.) but it was still kinda working, so I wanted to see if I could dump it. I haven't tried any of my other discs.
Re: DiscImageCreator
Posted: Mon Mar 27, 2023 11:17 am
by sarami
reentrant wrote:Thx. Btw, could you also add command line parameter for setting c2 offset value (if there's no value assume 0)?
https://www.mediafire.com/file/eq80y20l … st.7z/file
2nd value of /c2 is the c2 offset