Page 2 of 2
Re: [DONE] Redump integration in Dolphin?
Posted: Wed Aug 21, 2019 3:21 am
by iR0b0t
https://redump.info/datfile/ixl/serial,version
supported options = serial and/or version
separated by comma, order does not matter.
Re: [DONE] Redump integration in Dolphin?
Posted: Wed Aug 21, 2019 3:41 am
by JosJuice
Thank you!
For integrating this into Dolphin, would you prefer that we ship a copy of the dat file with every release of Dolphin, or would you prefer that Dolphin downloads the dat file from redump.org on behalf of the user? The former would place less of a load on the server, but the latter would enable people to get the hashes for new dumps without having to update Dolphin. (There aren't all that many undumped discs now, though... At least if you don't count demos and all the Korean Wii games.) If I do the latter, I'll make it download only if the user is trying to verify a disc (and with local caching), so the server isn't going to be getting a request for every person who uses Dolphin or anything like that.
Also, if we ship a copy of the dat file with Dolphin, is it fine to ship the Wii dat file too even though it's not publicly available on redump.org?
Re: [DONE] Redump integration in Dolphin?
Posted: Wed Aug 21, 2019 7:17 am
by iR0b0t
Yes, you can do both, gamecube & wii, and auto-download whenever needed. Server is powerful enough to handle it.
Re: [DONE] Redump integration in Dolphin?
Posted: Sat Aug 24, 2019 5:41 am
by JosJuice
I've created the Dolphin pull request:
https://github.com/dolphin-emu/dolphin/pull/8330
Feel free to unsticky this thread now, since there isn't much left to discuss.
Re: [DONE] Redump integration in Dolphin?
Posted: Sat Aug 24, 2019 7:56 am
by user7
Jos, anyway dolphin could blast a note about the Wii/gc missings in conjunction with this feature add? We're pretty much at a brick wall for finding rare stuff - such as euro Wii demos, etc.
Re: [DONE] Redump integration in Dolphin?
Posted: Sat Aug 24, 2019 8:50 am
by JosJuice
I suppose I could add a notice if you try to verify a disc that isn't in redump, but I don't know of a reliable way to distinguish between legit GameCube discs that should be in redump and custom homebrew GameCube discs that shouldn't be in redump. (For Wii discs I can check the signing and hashes.) Do you think I should add it despite that?
Re: [DONE] Redump integration in Dolphin?
Posted: Sat Aug 24, 2019 8:59 am
by user7
Re: [DONE] Redump integration in Dolphin?
Posted: Sat Aug 24, 2019 9:04 am
by JosJuice
Ah, I didn't think about embedding the miss lists into Dolphin. But some of the games there don't even have known game IDs (mainly the monthly Japanese GC discs), so I don't know if I can use those lists...
Or maybe you just meant I could include links to the miss lists for the user to check?
Re: [DONE] Redump integration in Dolphin?
Posted: Sat Aug 24, 2019 9:40 am
by user7
Yeah links. But ofc if you can look for missing versions somehow for games that would be cool too.